Repository navigation
Commit e3c7970
committed
tests: system-traffic: Fix checks for wrong checksums in NAT tests.
Tests are matching on words 'wrong' and 'bad' in tcpdump output to
capture reports about incorrect checksums. However, 'bad' is a valid
hex string and can occur as part of IPv6 flowlabel or some other parts
of the packet. Let's match on words instead of simply sub-strings.
Example of the failed check from our CI:
$ tcpdump -n -v "icmp6" -r p0.pcap 2>/dev/null | grep -E 'wrong|bad'
11:37:41.485535 IP6 (flowlabel 0xbad6a, hlim 64,
next-header ICMPv6 (58), ... fc00::2 > fc00::1:[icmp6 sum ok] ICMP6
Also, let's actually log the output so it's easier to understand what
happened from the log without the need to run tcpdump manually on the
captured pcap manually.
Chances to hit this issue are quite low, but it happened more than
once at this point.
Fixes: b020a41 ("System Tests: Enhance NAT tests.")
Acked-by: Eelco Chaudron <echaudron@ovn.org>
Signed-off-by: Ilya Maximets <i.maximets@ovn.org>1 parent 4ac74a2 commit e3c7970
1 file changed
Lines changed: 6 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7463 | 7463 | | |
7464 | 7464 | | |
7465 | 7465 | | |
7466 | | - | |
| 7466 | + | |
| 7467 | + | |
7467 | 7468 | | |
7468 | 7469 | | |
7469 | 7470 | | |
| |||
7552 | 7553 | | |
7553 | 7554 | | |
7554 | 7555 | | |
7555 | | - | |
| 7556 | + | |
| 7557 | + | |
7556 | 7558 | | |
7557 | 7559 | | |
7558 | 7560 | | |
| |||
8303 | 8305 | | |
8304 | 8306 | | |
8305 | 8307 | | |
8306 | | - | |
| 8308 | + | |
| 8309 | + | |
8307 | 8310 | | |
8308 | 8311 | | |
8309 | 8312 | | |
| |||
0 commit comments