Repository navigation
A quotient of logarithms tends to the logarithms of its arguments' limits - #2276
Merged
Rafael-SOWNet merged 2 commits intoOct 31, 2026
Conversation
…mits limit(ln(y + x) / ln(z + x), x, 0) was y / z, where it is ln(y) / ln(z), while the same limit with numbers, ln(x + 2) / ln(x + 3), was ln(2) / ln(3). SolveAsLogarithmDivision builds the quotient of the limits' logarithms, and returns it where it evaluates to a number; its last arm, reached for a symbolic limit, returned the quotient of the limits themselves. It now returns the quotient of their logarithms. LogarithmsOfSymbolicLimitsTest takes six symbolic quotients and one numeric one; the six fail on master. ln(1 + x) / ln(y + x) at 0, which was 1 / y, is 0 provided not ln(y) = 0. The suite, the trio, F#, AOT and the eight harnesses pass. Fixes #2271. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2276 +/- ##
==========================================
+ Coverage 86.70% 86.71% +0.01%
==========================================
Files 310 310
Lines 67869 67872 +3
Branches 19701 19701
==========================================
+ Hits 58843 58857 +14
+ Misses 4903 4891 -12
- Partials 4123 4124 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…-the-limits Both this branch and #2268 add a header rule after ModulusPhaseTest's; each keeps its own. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Rafael-SOWNet
deleted the
a-quotient-of-logarithms-tends-to-the-logarithms-of-the-limits
branch
October 31, 2026 01:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
limit(ln(y + x) / ln(z + x), x, 0)wasy / z, where it isln(y) / ln(z), while the same limit with numbers,ln(x + 2) / ln(x + 3), wasln(2) / ln(3).SolveAsLogarithmDivisionbuilds the quotient of the limits' logarithms and returns it when it evaluates to a number. Its last arm, reached for a symbolic limit, returned the quotient of the limits themselves. It now returns the quotient of their logarithms.limit(ln(y + x) / ln(z + x), x, 0)y / zln(y) / ln(z)limit(ln(a + 1/x) / ln(b + 1/x), x, +oo)a / bln(a) / ln(b)limit(ln(1 + x) / ln(y + x), x, 0)1 / y0 provided not ln(y) = 0LogarithmsOfSymbolicLimitsTest: its six symbolic cases fail on master, and the numeric one passes on both. The suite (18,236), the trio, F#, AOT and the eight harnesses pass locally.This touches the same function as #2275, in a different hunk.
Fixes #2271.
🤖 Generated with Claude Code