Repository navigation
Conversation
Infer JSON for data members when datacontenttype is absent or null, preserve explicit null payloads, and use an opaque content type for binary or absent payloads. Add 48 sync and async regression cases. Fixes BrighterCommand#4680
gabisonia
requested review from
DevJonny,
holytshirt,
iancooper and
preardon
as code owners
October 30, 2026 20:27
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Structured CloudEvents with omitted or null
datacontenttypepreviously threw during unwrapping. Inferapplication/jsonwhen adatamember is present, preserving JSON strings and explicit JSON null. Useapplication/octet-streamfor base64 payloads or events without data, since Brighter requires a content type even when the CloudEvent omits it.Track whether
datawas present so an explicit null payload remains distinct from an absent payload. Decode empty base64 payloads as binary and give the extracted body the resolved content type without mutating the header's content type.Adds 48 regression cases covering sync/async unwrapping, omitted/null content types, all JSON value kinds, arbitrary and JSON-looking binary bytes, empty binary payloads, and absent payloads. No public signature or dependency changes.
Related Issues
Fixes #4680
Type of Change
Checklist
Additional Notes
Please merge with a merge commit, per the contributing guide.