Repository navigation
fix(remote-connect): reconnect after server closes the transport - #3658
Merged
Merged
Conversation
Propagate Engine.IO and WebSocket close notifications to Socket.IO so account connections can reconnect and restore device presence. Close the engine input queue before notification to release blocked sends. Cover re-registration, RPC recovery, unacknowledged request failure without replay, and shutdown under backpressure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Server-initiated Engine.IO or WebSocket closes could leave the account connection waiting on open Socket.IO receivers, preventing automatic reconnection and device presence recovery.
Forward close events through both protocol layers and close the engine input queue before notifying the Socket.IO manager. Existing reconnect logic can then reauthenticate, register the device, and refresh presence without deadlocking on queued writes. Wire formats and reconnect policy are unchanged.
Verification
git diff --checkpassed.Remote control and peer messaging were exercised at the protocol level on one host. Physical Windows/macOS/mobile combinations were not exercised.