Skip to content

fix duplicate python SQL injection audit query ID - #246

Open
tvharini9 wants to merge 1 commit into
GitHubSecurityLab:mainfrom
tvharini9:fix-python-sql-injection-query-id
Open

tvharini9 wants to merge 1 commit into
GitHubSecurityLab:mainfrom
tvharini9:fix-python-sql-injection-query-id

Conversation

@tvharini9

Copy link
Copy Markdown

Summary

Fixes a duplicate query ID in the Python SQL injection audit queries.

Both SqlInjectionAudit.ql and SqlInjectionHeuristic.ql previously used:

githubsecuritylab/audit/sql-injection

The heuristic query now uses the unique ID:

githubsecuritylab/audit/sql-injection-heuristic

Background

The duplicate IDs were introduced in commit 9edecfb (Rename query IDs), which assigned the same replacement ID to both queries.

Changes

  • Updated the @id metadata in SqlInjectionHeuristic.ql.
  • Left query logic, severity, precision and tags unchanged.

Validation

  • Heuristic query compilation: passed.
  • Existing CWE-089 SQL injection audit test: passed (1/1).
  • Python query ID scan: no duplicate IDs found.
  • git diff --check: passed.

Only one query metadata line was changed.

@tvharini9

tvharini9 commented Oct 31, 2026 •

Copy link
Copy Markdown
Author

hi! This PR is ready for review. I've validated the heuristic query compilation and the existing CWE-089 audit test locally (1/1 passed).

I noticed the required CI checks are still waiting for status reports. Could a maintainer please check whether the workflow run needs approval and review the PR when convenient?

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant