Repository navigation
Conversation
Collaborator
Author
|
Verified that the new skills in
|
ludoch
force-pushed
the
cloudtasks-runtime-okhttp
branch
from
October 24, 2026 12:50
15e9a3f to
73920f3
Compare
ludoch
force-pushed
the
agent-skills-runtime-deps
branch
from
October 24, 2026 12:50
3b7e368 to
539240e
Compare
ludoch
force-pushed
the
cloudtasks-runtime-okhttp
branch
from
October 24, 2026 15:48
73920f3 to
e8f9158
Compare
ludoch
force-pushed
the
agent-skills-runtime-deps
branch
from
October 24, 2026 15:48
539240e to
8537760
Compare
ludoch
force-pushed
the
agent-skills-runtime-deps
branch
from
October 28, 2026 16:42
f8b236a to
209dee8
Compare
Collaborator
|
@gajjarc do we still need this? |
Checks that every class reachable from the App Engine classes bundled in runtime-impl-jetty12.jar and runtime-impl-jetty121.jar can be loaded from the runtime class path. Runs jdeps -verbose:class on each runtime-impl jar with the deployment jars on the class path, follows references starting from com.google.appengine.* and com.google.apphosting.* classes, and fails on any unexpected missing class.
ludoch
force-pushed
the
agent-skills-runtime-deps
branch
from
October 30, 2026 16:36
1f688ec to
311b7cd
Compare
Collaborator
Author
|
PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RuntimeJarDependencyClosureTest(CI guard)Adds
runtime/test/src/test/java/com/google/apphosting/runtime/RuntimeJarDependencyClosureTest.java, parameterized overruntime-impl-jetty12.jarandruntime-impl-jetty121.jar:jdeps -verbose:class(throughToolProvider) on the jar from the runtime deployment, withruntime-main.jarand theruntime-shared-*.jaron the class path.com.google.appengine.*/com.google.apphosting.*through the bundled libraries.KNOWN_MISSING_PACKAGESlist. The listed exceptions are pre-existing, on unused paths, each with a reason: antlr for the borgcron Groc parser, google-api-client for the Cloud Datastore v1 client,io.grpc.alts(DirectPath), Jetty ALPN, and JNDI transactions.com.google.auth.Credentials <- com.google.appengine.api.taskqueue.CloudTasksClientWrapper.jdepsisn't available (JRE only). It takes about 4 s per jar.Verified:
Both
runtime-impl-jetty12.jarandruntime-impl-jetty121.jarpass: