Repository navigation
fix: close review safety gaps and isolate standalone builds - #360
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reflect could run background commands outside a configured sandbox, mutate files in Plan/Review, and resolve child-session file paths in the parent workspace. HTTPS fetches also lost TLS hostnames, multiple audit writers broke the security chain, plugin uninstall accepted traversal, shell descendants outlived deadlines, and URL redaction retained tokens.
This change fixes all nine review findings and the five existing lint failures. It adds regression coverage for execution boundaries, working-directory isolation, certificate verification and SSRF, independent audit writers (including subprocesses), plugin removal, redaction, and preservation of parent workspaces. Setup and CI now use published dependencies; optional local Relay work uses a gitignored go.local.mod overlay.
Validation:
Behavior changes: sandboxed background commands now return an explicit error; Plan/Review reject general interpreters and mutating command forms; SSRF-safe fetches connect directly without environment proxies. Corrupt audit chains are rejected for append rather than silently extended.