Skip to content

fix: close review safety gaps and isolate standalone builds - #360

Merged
Patel230 merged 2 commits into
mainfrom
fix/review-safety-and-standalone
Nov 1, 2026
Merged

Patel230 merged 2 commits into
mainfrom
fix/review-safety-and-standalone

Conversation

@Patel230

@Patel230 Patel230 commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Reflect could run background commands outside a configured sandbox, mutate files in Plan/Review, and resolve child-session file paths in the parent workspace. HTTPS fetches also lost TLS hostnames, multiple audit writers broke the security chain, plugin uninstall accepted traversal, shell descendants outlived deadlines, and URL redaction retained tokens.

This change fixes all nine review findings and the five existing lint failures. It adds regression coverage for execution boundaries, working-directory isolation, certificate verification and SSRF, independent audit writers (including subprocesses), plugin removal, redaction, and preservation of parent workspaces. Setup and CI now use published dependencies; optional local Relay work uses a gitignored go.local.mod overlay.

Validation:

  • Full race suite: 156 packages passed.
  • make module-check boundaries fmt-check lint: passed, zero lint issues.
  • make build and Windows amd64 cross-build: passed.
  • make security: no reachable vulnerabilities.
  • reflect verify: project tests pass; the pre-existing local audit-log chain break at entry 200 remains detected. No historical audit data was rewritten.

Behavior changes: sandboxed background commands now return an explicit error; Plan/Review reject general interpreters and mutating command forms; SSRF-safe fetches connect directly without environment proxies. Corrupt audit chains are rejected for append rather than silently extended.

@Patel230
Patel230 enabled auto-merge (squash) November 1, 2026 19:09
@Patel230
Patel230 merged commit 11f45e4 into main Nov 1, 2026
23 checks passed
@Patel230
Patel230 deleted the fix/review-safety-and-standalone branch November 1, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant