Skip to content

fix(chat): keep greetings free of repository tool activity - #361

Merged
Patel230 merged 1 commit into
mainfrom
fix/quiet-conversational-turns
Nov 2, 2026
Merged

Patel230 merged 1 commit into
mainfrom
fix/quiet-conversational-turns

Conversation

@Patel230

@Patel230 Patel230 commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Typing Hi in the TUI triggered file listings and reads of project instructions before the greeting. Terminal metadata hid the conversational message from classification, and past tool use disabled the tool-free path. Greetings now receive a minimal prompt with tools disabled, including after previous repository work.

Changes

  • Share a conservative whole-message greeting classifier between terminal capture and the engine; keep requests such as Hi fix bug on the normal tool path.
  • Preserve pending terminal context for the next actual task instead of attaching it to greetings.
  • Skip workspace, memory and workflow prompt injections on conversational turns, request tool_choice=none, and suppress unsolicited provider tool calls with a text fallback.
  • Add regression coverage for terminal context, prior tool history, provider-ignored tool choice and subsequent work requests; document the behavior in the changelog.

Testing

make fmt-check lint: passed, 0 issues
make boundaries build: passed
Race-enabled prompt, sessioncapture, engine, testaudit and ctxmgr tests: passed
make test-race: passed (full suite)

The full local race suite passed on the final run. An earlier run hit the unchanged timing-sensitive ctxmgr/TestConcurrentGathering threshold under load; the focused rerun also passed.

Checklist

  • Conventional Commit and signed commit
  • make build passes
  • make lint passes
  • make test passes locally with -race enabled
  • Regression tests added
  • Public functions have godoc comments
  • CHANGELOG.md updated under Unreleased
  • No secrets, tokens or PII added
  • No co-author trailers

@Patel230
Patel230 enabled auto-merge (squash) November 2, 2026 02:58
@Patel230
Patel230 merged commit 20364a1 into main Nov 2, 2026
23 checks passed
@Patel230
Patel230 deleted the fix/quiet-conversational-turns branch November 2, 2026 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant