Skip to content

remove j4ml dependency - #1489

Merged
baltzell merged 13 commits into
developmentfrom
j4ml
Nov 3, 2026
Merged

baltzell merged 13 commits into
developmentfrom
j4ml

Conversation

@baltzell

@baltzell baltzell commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator

Requires #1491 and #1541.

@baltzell
baltzell marked this pull request as ready for review October 29, 2026 21:52
@c-dilks

c-dilks commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

updated kpp-ai and rebased this j4ml branch onto it

@c-dilks

c-dilks commented Oct 30, 2026

Copy link
Copy Markdown
Member

Looking great so far!

image

@c-dilks

c-dilks commented Oct 30, 2026

Copy link
Copy Markdown
Member

The above CI failures indicate that slf4j is no longer found at runtime; that is because it was being resolved through some j4ml packages, transitively, e.g.:

org.jlab.clas12.detector:clas12detector-mltn:jar:14.2.3-SNAPSHOT
+- j4ml:j4ml-neuroph:jar:0.9-SNAPSHOT:compile
   +- com.github.neuroph:neuroph-core:jar:2.98:compile
      +- org.slf4j:slf4j-api:jar:1.7.6:compile

However, djl also needs it at runtime, so it needs to be added to our installation classpath.

The reconstruction/alert module copies some of djl's runtime dependencies, which ultimately are copied into our installation prefix class path (/coatjava/lib/services); slf4j, among others, are not included.

Instead of leaving it up to the alert module's POM, I decided to pull this stuff out into a new dedicated module, common-tools/djl-runtime. Instead of including just the artifacts we need, I use the djl runtime scope, so there are a few more JARs in the prefix, but it reduces the maintenance burden here (if djl needs a new runtime dependency, we won't be "surprised").

Here's the diff of the prefix classpath file tree:

2026-10-30-181259_1436x1244_scrot

@c-dilks c-dilks added the maven label Oct 30, 2026
@c-dilks

c-dilks commented Oct 30, 2026

Copy link
Copy Markdown
Member

Sorry for hijacking this PR, to see what I did,

git diff fc8060635..HEAD

@raffaelladevita raffaelladevita left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't have the expertise to review the new djl-runtime module but can approve the rest

@c-dilks

c-dilks commented Nov 2, 2026

Copy link
Copy Markdown
Member

don't have the expertise to review the new djl-runtime module but can approve the rest

@baltzell are you okay with how djl is handled here?

@baltzell
baltzell merged commit 0bbb6df into development Nov 3, 2026
25 checks passed
@baltzell
baltzell deleted the j4ml branch November 3, 2026 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants