Repository navigation
Add en face slab viewing - #978
Merged
Merged
Conversation
✅ Deploy Preview for volview-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
PaulHax
marked this pull request as draft
October 19, 2026 18:53
PaulHax
changed the title
PaulHax
commented
Oct 28, 2026
PaulHax
commented
Oct 28, 2026
PaulHax
force-pushed
the
oct-en-face
branch
2 times, most recently
from
October 29, 2026 00:34
6362f0f to
59b60f2
Compare
PaulHax
changed the title
PaulHax
force-pushed
the
segmentation-filename-matching
branch
from
October 29, 2026 00:53
89ea736 to
492e025
Compare
PaulHax
marked this pull request as ready for review
October 29, 2026 14:04
2 of 3 tasks
PaulHax
force-pushed
the
oct-en-face
branch
5 times, most recently
from
November 1, 2026 16:21
db74f7f to
990a169
Compare
Read the projection axis from the en face store when moving the crosshairs instead of threading it through the widget props, and give the toolbar one loop for both tool groups and tool availability one en face branch. Drop code that repeats existing behavior: the constant opacity function vtk.js already applies, an OCT coordinate comparison that vtk.js areEquals provides, an unreachable Sum preset guard, unused returns and fields, and needless casts and locals. Share the auto window range type and the slab method list between the windowing store, the slab estimator, the session schema and the controls. Re-encode the retinal sample thumbnail as a 128 px JPEG like the other sample thumbnails.
Replace about thirty hand-written sequences that open the En face controls, expand Projection and set the slab with shared helpers, and reuse the page object menu helpers, the tooltip lookup and one tool button selector instead of local copies. Share En face view activation and OCT loading between the unit specs, reuse the image cache cleanup helper, collapse the OCT geometry rejection cases into one table, and replace an assertion that could not fail. The fixture builders now share one DICOM string overwrite, one long-form VR list and one VTI writer.
Only VTI can describe a grid whose voxel indices start at an offset, and en face does not need to support one. Drop the code that handled it: the extent offset in the vtk.js reslice mapper patch, extent-based 2D slice ranges, the extent minimum in the slab plane and reference line geometry, and the crosshairs refusal for offset grids, along with their tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an En face view for grayscale 3D volumes, including native retinal OCT. Mean, maximum, and sum projections use an adjustable slab along any source-grid axis, with independent contrast, pan, zoom, crosshairs, and reference lines. Changing the projection refits automatic contrast, and the view configuration is saved with the session.
Support native OCT spatial metadata and retain valid DICOM pixel spacing and multiframe spacing. The shared slab representation uses vtk.js reslice rendering with corrections for slab sampling. See the view implementation and mapper patch.
Includes the uint8 retinal sample with unchanged uint8 companion labels loaded by segmentation filename matching.