Repository navigation
Update cookbook titles for docs display - #351
hannahbaumann wants to merge 11 commits into
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
|
IAlibay
left a comment
IAlibay
left a comment
There was a problem hiding this comment.
One larger question on tense and one smaller nit.
| "metadata": {}, | ||
| "source": [ | ||
| "# BespokeFit: Using bespoke force field parameters with OpenFE protocols\n", | ||
| "# Use bespoke parameters with BespokeFit\n", |
There was a problem hiding this comment.
I notice you're changing the text away from present participle - is this intentional?
There was a problem hiding this comment.
Yes, this was intentional, mostly to shorten titles, and also because if now it's How-to ... it works better I thought. But if others think the other version is better, I can also switch to that.
There was a problem hiding this comment.
Ah I see, so it's "How to X"? That makes a lot of sense, thanks!
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
| @@ -4,7 +4,7 @@ | |||
| "cell_type": "markdown", | |||
There was a problem hiding this comment.
Maybe we could hit part of OpenFreeEnergy/openfe#2283 with this change as well and drop bespokefit from the title? I can then update the introduction in another PR to say BespokeFit is just one example of the input files we can use.
What about "Using custom force field parameters" as a more general title?
Reply via ReviewNB
There was a problem hiding this comment.
I like the idea of changing the title and the explanation to make it more broad, but I would suggest we can maybe change the title together with the text in a follow up PR?
| @@ -5,7 +5,7 @@ | |||
| "id": "035c0099-6892-4ed2-b0d6-80b1c247c1e7", | |||
There was a problem hiding this comment.
Should it be -> Plan a LigandNetwork to match the use of the AlchemicalNetwork in the other cookbook titles?
Reply via ReviewNB
Co-authored-by: Hannah Baumann <43765638+hannahbaumann@users.noreply.github.com>
No description provided.