Repository navigation
Arc walls of extrusions, outline sweeps and their shells mesh without needle triangles (OPE-101) - #34
Merged
Merged
Conversation
…ithout needles An extruded or one-segment swept profile with an arc edge gives zero-area triangles on its curved wall, and a weld at 1e-8 m leaves edges used by more than two triangles. These tests mesh the display buffers at the static bucket and at the 2 mm drawing bucket and require no zero-area triangle, no two corners closer than 1 micrometre and every welded edge used exactly twice. Signed-off-by: Vishwajeet Mane <manevishwajeet1@gmail.com>
Builders pad a face's uv box by the geometric tolerance. A padded box fails the exact rectangle test, so the face goes to the trimmed path, which laid its even grid over the padded box. Each grid line then sat 1e-8 to 5e-8 away from the edge sample it should meet, and the merge kept both: one zero-width strip per arc sample on every extruded or swept arc wall. The even grid now spans the outer trim loop, taken before holes are shifted, with its count scaled from the box so the density stays the one the count was made for (a loose two-turn box keeps one turn's count). The B-rep does not change. Expected diff: 69 golden keys, all on faces with padded boxes (arc extrusions, sweeps, shells, curved booleans): mesh and mesh-measured volume only; triangles in the changed sections 191,050 to 163,346, none more. Wall chord deviation is unchanged (D wall at deflection 0.73 mm: 3.649e-4 m before and after). The stored meshes arc-edged-extrusion and arc-edged-extrusion-with-holes held 44 needle triangles each from the old kernel and are re-recorded from this one (144 to 100 and 164 to 120 triangles); their B-rep files do not change. Not in this change: an arc edge sampled more coarsely than the face grid still leaves T-junctions on the wall rows; that has a separate cause in how edge sample counts are chosen. Signed-off-by: Vishwajeet Mane <manevishwajeet1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix needle triangles