Repository navigation
fix: accept DataFrame inputs in abstract Function.run - #787
Merged
Merged
Conversation
Signed-off-by: Tianlang (Jackie) Chen <305351710+jackiectl2@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Accept pandas and Polars DataFrames in abstract Function.run without evaluating their truth value. Use None to distinguish an omitted input from a supplied frame, including an empty frame. Test both frame types, empty/nonempty input, output values/types, pandas indexes, and reusing the stored input with run(). Regenerate the tracked C file with Cython 3.3.0.
Validation
Regression before: all 4 DataFrame cases fail. After building the extension against bundled TA-Lib C 0.8.3: the complete suite passes, 2037 passed / 1 skipped. The CI Flake8 selection E9,F63,F7,F82 and git diff --check pass. Verified on Linux/Python 3.12 with GCC; Windows/macOS were not run.