refactor(lit-query/BaseController): type the context callback value as possibly 'undefined' and remove its 'no-unnecessary-condition' disable by sukvvon · Pull Request #12311 · TanStack/query

sukvvon · 2026-10-23T17:13:07Z

🎯 Changes

BaseController: type the queryClientContext callback value as QueryClient | undefined, since the provider sends undefined when it loses its client. The value === undefined check is then no longer flagged, so its no-unnecessary-condition disable is removed.

The public types are unchanged.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Refactor
- Clarified the type of the query client value in the context callback. Callback behavior is unchanged.

…efined' and give the remaining 'no-unnecessary-condition' disables a reason

changeset-bot · 2026-10-23T17:13:13Z

⚠️ No Changeset found

Latest commit: 2361215

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

nx-cloud · 2026-10-23T17:13:34Z

View your CI Pipeline Execution ↗ for commit 2361215

Command	Status	Duration	Result
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	2s	View ↗
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	46s	View ↗

☁️ Nx Cloud last updated this comment at 2026-10-31 16:02:18 UTC

github-actions · 2026-10-23T17:13:56Z

🚀 Changeset Version Preview

10 package(s) bumped directly, 14 bumped as dependents.

🟩 Patch bumps

Package	Version	Reason
`@tanstack/angular-query-experimental`	5.105.0 → 5.105.1	Changeset
`@tanstack/eslint-plugin-query`	5.105.0 → 5.105.1	Changeset
`@tanstack/lit-query`	0.2.31 → 0.2.32	Changeset
`@tanstack/preact-query`	5.105.0 → 5.105.1	Changeset
`@tanstack/query-core`	5.105.0 → 5.105.1	Changeset
`@tanstack/query-persist-client-core`	5.105.0 → 5.105.1	Changeset
`@tanstack/react-query`	5.105.0 → 5.105.1	Changeset
`@tanstack/solid-query`	5.105.0 → 5.105.1	Changeset
`@tanstack/svelte-query`	6.3.6 → 6.3.7	Changeset
`@tanstack/vue-query`	5.105.0 → 5.105.1	Changeset
`@tanstack/preact-query-devtools`	5.105.0 → 5.105.1	Dependent
`@tanstack/preact-query-persist-client`	5.105.0 → 5.105.1	Dependent
`@tanstack/query-async-storage-persister`	5.105.0 → 5.105.1	Dependent
`@tanstack/query-broadcast-client-experimental`	5.105.0 → 5.105.1	Dependent
`@tanstack/query-devtools`	5.105.0 → 5.105.1	Dependent
`@tanstack/query-sync-storage-persister`	5.105.0 → 5.105.1	Dependent
`@tanstack/react-query-devtools`	5.105.0 → 5.105.1	Dependent
`@tanstack/react-query-next-experimental`	5.105.0 → 5.105.1	Dependent
`@tanstack/react-query-persist-client`	5.105.0 → 5.105.1	Dependent
`@tanstack/solid-query-devtools`	5.105.0 → 5.105.1	Dependent
`@tanstack/solid-query-persist-client`	5.105.0 → 5.105.1	Dependent
`@tanstack/svelte-query-devtools`	6.3.6 → 6.3.7	Dependent
`@tanstack/svelte-query-persist-client`	6.3.6 → 6.3.7	Dependent
`@tanstack/vue-query-devtools`	6.3.6 → 6.3.7	Dependent

pkg-pr-new · 2026-10-23T17:15:43Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@12311

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@12311

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@12311

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@12311

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@12311

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@12311

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@12311

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@12311

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@12311

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@12311

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@12311

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@12311

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@12311

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@12311

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@12311

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@12311

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@12311

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@12311

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@12311

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@12311

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@12311

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@12311

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@12311

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@12311

commit: 2361215

github-actions · 2026-10-23T17:15:57Z

size-limit report 📦

Path	Size
react full	11.74 KB (0%)
react minimal	8.58 KB (0%)

coderabbitai · 2026-10-23T17:16:44Z

No actionable comments were generated in the recent review.

Recent review info

Run configuration

Source mode: Auto
Repository: TanStack/query
Branch: refactor/lit-query-client-undefined-checks
File: .coderabbit.yaml
Commit: 2361215
Layers: Repository YAML
Review profile: CHILL
Plan: Advanced
Run ID: bf112205-d50e-443c-822c-9dec623418ea

Commits

Reviewing files that changed from the base of the PR and between 772ada1 and 2361215.

Files selected for processing: 1

packages/lit-query/src/controllers/BaseController.ts

Files with no reviewable changes: 1

packages/lit-query/src/controllers/BaseController.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.

Walkthrough

The context callback parameter now has the explicit type QueryClient | undefined. The comment about the provider sending undefined when its client is removed was deleted.

Changes: Lit Query maintenance

Layer / File(s)	Summary
Callback typing and comment removal `packages/lit-query/src/controllers/BaseController.ts`	The context callback parameter is explicitly typed as `QueryClient

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Refactor

Suggested reviewers: chughgaurav

Merge Risk: Minimal · up to 23612

No merge-blocking issue is evident from this change; it is ready for normal checks.

Pre-merge checks: 5

Check name	Status	Explanation
Title check		The title clearly identifies the main change: typing the context callback value as possibly undefined and removing the unnecessary-condition disable. It is specific, although somewhat long.
Description check		The description explains the change and motivation, includes all required template sections, reports testing, confirms AI policy compliance, and states that no release is required.
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.

Finishing Touches

Generate docstrings

Commit to this branch
Create a new PR

Generate unit tests (beta)

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

# Conflicts: # packages/lit-query/src/QueryClientProvider.ts # packages/lit-query/src/controllers/BaseController.ts

refactor(lit-query): type the context callback value as possibly 'und…

772ada1

…efined' and give the remaining 'no-unnecessary-condition' disables a reason

sukvvon self-assigned this Oct 23, 2026

Merge branch 'main' into refactor/lit-query-client-undefined-checks

ecf190a

# Conflicts: # packages/lit-query/src/QueryClientProvider.ts # packages/lit-query/src/controllers/BaseController.ts

Merge branch 'main' into refactor/lit-query-client-undefined-checks

2361215

Navigation Menu

Repository navigation

refactor(lit-query/BaseController): type the context callback value as possibly 'undefined' and remove its 'no-unnecessary-condition' disable - #12311

refactor(lit-query/BaseController): type the context callback value as possibly 'undefined' and remove its 'no-unnecessary-condition' disable#12311
sukvvon wants to merge 3 commits into
mainfrom
refactor/lit-query-client-undefined-checks

sukvvon commented Oct 23, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

changeset-bot Bot commented Oct 23, 2026 •

edited

Loading

Uh oh!

nx-cloud Bot commented Oct 23, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 23, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Oct 23, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 23, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 23, 2026 •

edited

Loading

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

sukvvon commented Oct 23, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

changeset-bot Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

nx-cloud Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Changeset Version Preview

🟩 Patch bumps

Uh oh!

pkg-pr-new Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

coderabbitai Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Oct 23, 2026 •

edited by coderabbitai Bot

Loading

changeset-bot Bot commented Oct 23, 2026 •

edited

Loading

nx-cloud Bot commented Oct 23, 2026 •

edited

Loading

github-actions Bot commented Oct 23, 2026 •

edited

Loading

pkg-pr-new Bot commented Oct 23, 2026 •

edited

Loading

github-actions Bot commented Oct 23, 2026 •

edited

Loading

coderabbitai Bot commented Oct 23, 2026 •

edited

Loading