Skip to content

feat(aidd-vcs): answer pull and merge request review comments - #1128

Open
alexsoyes wants to merge 6 commits into
nextfrom
feat/review-comment-faq
Open

alexsoyes wants to merge 6 commits into
nextfrom
feat/review-comment-faq

Conversation

@alexsoyes

@alexsoyes alexsoyes commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

🎯 What & why

Add aidd-vcs:06-answer-comments to answer pull or merge request review feedback and track pending decisions. PR and MR discussions belong to VCS; the DEV review skill keeps its existing diff-review flow.

🛠️ How it works

  • Answer review threads and update one summary comment, then offer to run the skill that captures durable project learnings with that summary.
  • Preserve done, answer, user-call and todo, with evidence-linked replies. Once the user states a decision, acknowledge it and resolve the user-call; any implementation is a separate action. Still-waiting threads remain in the summary without duplicate replies.
  • No source edits or automatic knowledge writes. The learning skill handles recording after the user accepts the handoff.
  • Register the standalone skill in VCS and regenerate catalogs and counts. Preserve the latest next review implementation and tests.

🧪 How to verify

  • Passed pnpm exec lefthook run pre-commit (966 script tests, architecture, links, generated docs, CLI lint and typecheck).
  • Passed pnpm exec lefthook run pre-push (knip; 6,875 CLI tests passed, 1 skipped).
  • git diff origin/next...HEAD -- plugins/aidd-dev scripts/__tests__/a-review-appends-a-round-and-scores-the-whole-plan.test.js is empty.

⚠️ Heads-up

The skill has not been rerun against a live pull or merge request.

✅ I certify

  • I DO CERTIFY I READ EACH LINE OF THE PULL REQUEST BECAUSE I AM A SOFTWARE ENGINEER, NOT A AI PUPPY.

@alexsoyes
alexsoyes force-pushed the feat/review-comment-faq branch from 066e419 to 128df66 Compare October 29, 2026 10:40
@alexsoyes alexsoyes changed the title feat(aidd-orchestrator): reply to review comments in one line and list the user's calls in a FAQ feat(aidd-dev): answer a pull request's review comments from the review skill Oct 29, 2026
…kill

Answer each review comment in one line, resolve the settled threads, ask the user's calls in their own thread, and propose the feedback worth keeping as learnings.
@alexsoyes
alexsoyes force-pushed the feat/review-comment-faq branch from dfdb4d6 to d6c4ea4 Compare November 2, 2026 02:36

@alexsoyes alexsoyes left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test de la skill de revue (answer-comments / propose-learnings) : 3 commentaires, un par catégorie.

@alexsoyes

alexsoyes commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor Author

Review comments

Done: 1 (b309633). Answered: 2.

@alexsoyes
alexsoyes marked this pull request as ready for review November 2, 2026 05:25
@alexsoyes
alexsoyes requested a review from a team as a code owner November 2, 2026 05:25
@alexsoyes alexsoyes changed the title feat(aidd-dev): answer a pull request's review comments from the review skill feat(aidd-vcs): answer pull request review comments in a dedicated skill Nov 3, 2026

@alexsoyes alexsoyes left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tu en penses quoi Baptiste ? J'ai pas mis le système de trigger de review depuis l'orchestrator

@alexsoyes alexsoyes changed the title feat(aidd-vcs): answer pull request review comments in a dedicated skill feat(aidd-vcs): answer pull and merge request review comments Nov 3, 2026
@alexsoyes
alexsoyes requested a review from blafourcade November 3, 2026 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants