Repository navigation
Conversation
AlignedIndentFilter._process_case appended a None END token when END was missing or nested inside a subgroup, then crashed in token_index during insert_before. Skip a missing END, guard empty case arms, and tolerate tokens that are not direct children. Fixes andialbrecht#886
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #886.
sqlparse.format(..., reindent_aligned=True)on malformed CASE input such as:raised
ValueError: None is not in listinsidetoken_index/insert_before.Cause
AlignedIndentFilter._process_casealways appended the END aligner fromtoken_next_by(END). When END is missing as a direct child (here it is nested inside an Assignment subgroup), that token isNone, and the nextinsert_before(None, ...)crashes.Fix
end_token is not None.stmt is None.ValueErrorfrominsert_beforewhen the token is not a direct child.Valid CASE alignment is unchanged.
Verification
tests/test_regressions.py+TestFormatReindentAligned