Repository navigation
Read promoted Parquet dictionaries natively - #26977
Draft
Rich-T-kid wants to merge 3 commits into
Draft
Rich-T-kid wants to merge 3 commits into
Rich-T-kid wants to merge 3 commits into
Conversation
Contributor
Author
|
Hosted ClickBench result: #26964 (comment) With dictionary mode enabled on both sides, this change reduced total time from 22.22s to 18.87s (-15.1%) with 3 faster, 0 slower, and 40 unchanged queries in the primary comparison. Q10 improved 198.86ms -> 65.91ms (3.02x), Q11 211.87ms -> 76.34ms (2.78x), and Q23 6146.32ms -> 2992.38ms (2.05x). Peak RSS fell from 12.6 GiB to 11.3 GiB. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is stacked on #26973; the final two commits are the change in this PR.
When the table schema uses
Dictionary(Int32, Utf8)but the physical Parquet schema isLargeBinary, the reader currently emits plain values andDecoderProjectiondictionary-encodes every row. Preserve the physical value type in the reader schema instead, so arrow-rs decodes dictionary keys directly and the projection casts only the distinct dictionary values. The same rule handles Utf8/LargeUtf8 offset-width mismatches.The Q23 profile no longer contains
pack_byte_to_dictionaryorGenericByteDictionaryBuilder::append_array; it now enters parquet-rsDictionaryDecoderdirectly. A controlled ClickBench run is pending on #26964.Validated with
cargo test -p datafusion-datasource-parquet --lib, package clippy with all targets/features, and the repository pre-push checks.Closes #26976.