Repository navigation
Allow heartbeat retries while a realtime TsFile is in flight - #19075
Merged
Merged
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19075 +/- ##
============================================
- Coverage 48.11% 48.09% -0.02%
- Complexity 621 625 +4
============================================
Files 5572 5572
Lines 410286 411486 +1200
Branches 54129 54170 +41
============================================
+ Hits 197408 197917 +509
- Misses 212878 213569 +691 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jt2594838
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




When region-level downgrading is active, a realtime TsFile can remain in flight while the sink needs heartbeat events to drive retry progress. The source now supplies ordinary heartbeats during that window while keeping later TsFiles and completion barriers ordered behind the in-flight file.
The regression test covers heartbeat delivery and event ordering. Its setup drains the pending queue before enqueueing a heartbeat after a completion barrier so existing heartbeat coalescing does not invalidate the ordering assertions.
Validation: Spotless and
git diff --checkpassed.PipeRealtimeExtractTestpassed locally after a clean reactor build with the build cache disabled: 20 tests, 0 failures, 0 errors, 0 skipped. The full unit-test suite was not rerun.