Skip to content

🎨 Palette: Add keyboard focus states to Toast, Modal, and HubTile components - #297

Open
bobdivx wants to merge 1 commit into
mainfrom
palette-ux-focus-states-10692825827976786201
Open

bobdivx wants to merge 1 commit into
mainfrom
palette-ux-focus-states-10692825827976786201

Conversation

@bobdivx

@bobdivx bobdivx commented Nov 1, 2026

Copy link
Copy Markdown
Owner

This PR introduces a small UX accessibility improvement by adding missing focus-visible states to base UI components. This ensures keyboard users can clearly identify which element currently has focus.

Changes:

  • Added focus-visible:outline-2 focus-visible:outline-[var(--color-accent)] to the Toast action and close buttons.
  • Added focus-visible:outline-2 focus-visible:outline-[var(--color-accent)] to the Modal close button.
  • Added focus-visible:outline-2 focus-visible:outline-[var(--color-accent)] to HubTile (both regular and add tiles).
  • Maintained the requested < 50 lines requirement and used existing design patterns.

Testing:

  • Ran pnpm run test:web - all tests passed.
  • Ran pnpm run check:forbidden - no issues found.

PR created automatically by Jules for task 10692825827976786201 started by @bobdivx

This commit adds `focus-visible` styling (using the app's accent color) to key interactive elements to improve keyboard navigation accessibility:
- Action and close buttons in the Toast component.
- The close button in the Modal component.
- The interactive HubTile and HubAddTile components.

This ensures screen reader and keyboard-only users can clearly see which element has focus.

Co-authored-by: bobdivx <6737167+bobdivx@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant