Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #515
initializeandloadNativeLibsset theirAtomicBooleanbefore doing the work, so a throw left them marked as done. A retry then returned without error andReactNativeBrownfield.sharedwas never set.This PR moves both guards into a small
RetryableOncehelper. It still runs the block at most once and still skips concurrent calls, but a block that throws no longer counts, so the next call runs it again. The error itself still propagates. Successful starts behave as before.Testing
RetryableOnceTest: a completed block does not run again; a block that throws runs again on the next call../gradlew :callstack_react-native-brownfield:testDebugUnitTest(inapps/RNApp/android) andyarn lintpass.