Repository navigation
Conversation
Align direct exception-instance dispatch with the existing exc_info tuple path and cover formatting, show output, traceback states, styles, and invalid inputs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
format()documents accepting an exception instance, but its direct-instance dispatch only recognizesException. Consequently, an explicitly passedKeyboardInterrupt,SystemExit, orGeneratorExitraisesValueError, even though formatting the equivalentsys.exc_info()-style tuple already works:Use
BaseExceptionin the existing dispatch check so direct instances follow the same path as exception tuples.show()benefits through its existing call toformat(). This does not change exception catching or traceback rendering.The regressions cover instances with and without tracebacks, plaintext and colored output, suppression options,
show()output, ordinary exceptions, and rejection of unrelated inputs/classes.Validation
show()smoke checks.AI-assisted implementation and review; no claim of production use. Existing exception-group rendering limitations are outside this change.