Repository navigation
Conversation
- Reject OAuth metadata endpoints off the deployment origin or under a workspace app path, without echoing them. - Send OAuth POSTs with maxRedirects: 0. - Show OAuth failures in a modal's plain detail, not a notification that renders command links. - Clean up superseded or disposed flows, and open the browser without awaiting it so early rejections reach the caller. - Ignore a coder.alternativeWebUrl that is not http(s).
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keeps OAuth endpoints, requests, and error text on the deployment's own origin.
/@user/...) are rejected, and the error does not echo them.maxRedirects: 0, so they are never resent to another URL.[text](command:...)links in server text.stateis no longer logged.coder.alternativeWebUrl: ignored unless it is an http(s) URL.Not in this PR: OAuth requests still carry the session token (revocation relies on it), and the dialog can start a second flow after another window's login wins.
Stacked on #1176; review that first.