Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## staging #1484 +/- ##
========================================
Coverage 10.74% 10.74%
========================================
Files 1132 1132
Lines 113993 113993
========================================
Hits 12254 12254
Misses 101739 101739 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on Dan's #1404 (commit 8ec9f17, unchanged). Linux camera (QR scanning) is broken in every Linux artifact we ship.
Cause
libcamera_linux.sois bundled (since #1317) but needslibopencv_wrapper.so, which the plugin never bundles, plus about 50 hostlibopencv_*.so.406libraries, and its RUNPATH points at the CI build tree. It fails to load on any user machine. The flatpak also had no OpenCV and only--device=dri.Changes on top of #1404
--device=alland:create)./app/lib(it went to lib64 by default), IPP and apps off for an offline build, cleanup of headers and cmake files,WITH_LIBV4Ldropped.-Wl,--no-as-needed, because the SDK's--as-neededdropped its NEEDED onlibopencv_wrapper.soand dlsym failed.scripts/linux/build_opencv_static.shbuilds a minimal static OpenCV 4.10 (core, imgproc, imgcodecs, videoio) into the CI image at/opt/opencv-static, and the image no longer installslibopencv-dev.linux/CMakeLists.txttemplate: readsSTACKWALLET_OPENCV_DIR, bundles the wrapper, RUNPATH$ORIGIN, static libstdc++,--exclude-libs,ALL,-Bsymbolic.prepare_release_bundle.py: fails the build if the camera libraries don't load from the bundle;--check-onlymode for the AppImage; 7 unit tests..github/actions/static-opencvwith a cache keyed on the script hash.Tested, with a real USB webcam (Depstech, /dev/video0)
libopencv_wrapper.soneeds GLIBC_2.38. The bundle already needs 2.39 forlibepic_cash_wallet.so, so this isn't newNot tested: Stack Duo and Campfire builds, a real CI run (nothing has gone to GitHub), the AppImage as a whole.
The same changes for release builds are in sneurlax/stack_releases PR (branch
fix/flatpak-opencv-camera), because releases generate their own manifest inlinux_release.dart.libopencv-dev in the CI image?
I recommend dropping it, as this branch does. With it installed, camera-linux's
find_package(OpenCV)can silently pick the shared system OpenCV, which is exactly how the current broken bundles were produced; without it the only OpenCV in the image is the static one, and the bundle check catches anything else. Developer machines still needlibopencv-devfor localflutter run, and that stays in the docs.