Repository navigation
feat: Added explanation prop to date picker components - #1368
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Explanation rendering discards caller-provided label customizations and lacks keyboard access.
3 open issues
What changed in this PR
Adds explanation tooltips to the library’s single-date and date-range pickers.
Changes:
- Adds explanation text and tooltip placement props, requiring a label.
- Adds shared label layout styling.
- Adds tooltip interaction stories and missing-label validation tests.
| File | Description |
|---|---|
| src/molecules/DateRangePicker/DateRangePicker.tsx | Adds explanation props and label integration. |
| src/molecules/DateRangePicker/DateRangePicker.test.tsx | Tests missing-label validation. |
| src/molecules/DateRangePicker/DateRangePicker.stories.tsx | Demonstrates and tests explanation tooltips. |
| src/molecules/DatePicker/DatePicker.tsx | Adds explanation props and label integration. |
| src/molecules/DatePicker/DatePicker.test.tsx | Tests missing-label validation. |
| src/molecules/DatePicker/DatePicker.styles.ts | Adds shared label-and-icon layout. |
| src/molecules/DatePicker/DatePicker.stories.tsx | Demonstrates and tests explanation tooltips. |
Review effort: Balanced
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira links
Issue
Description
Added explanation props to date picker components