Repository navigation
Conversation
CallActivityTypeConversionTest and the CMMN TypeConversionTest asserted that a 10 day period is between 239h and 240h01m from now. A period is added in calendar days, so the span is 241h when it crosses a DST change, and the tests fail for the days before it. Compute the expected end with ZonedDateTime.plus(Period) and assert it is within a minute. BoundaryTimerEventTest asserted the timer due date is within 100 ms of a timestamp taken before the process start, which fails on a loaded machine. Allow 5 seconds. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some tests fail depending on the date or machine load. None of them are related to the product code.
CallActivityTypeConversionTestand the CMMNTypeConversionTestThey assert that a
P10Dperiod converted to a date is between 239h and 240h01m from now.DefaultVariableValueConversionHandleradds aPeriodto aZonedDateTimein calendar days, so when the 10 days cross a daylight saving change the span is 241h (or 239h) and the assertions fail. Right now (US DST ends on Nov 1) they fail onmain.The tests now compute the expected end with
ZonedDateTime.now().plus(Period.ofDays(10))and assert that the result is within one minute of it. This is stricter than the previous one hour window, and it is independent of the time zone and date.BoundaryTimerEventTestThree tests assert that the timer due date is within 100 ms of a timestamp taken before the process is started. That only holds when process start-up is very fast; it failed once for me under load (
testRescheduleRepeatBoundaryTimer) and passed on rerun. The tolerance is now 5 seconds. The tests still check that the timer is due about one hour out.Verification
CallActivityTypeConversionTestfails on currentmainand passes with this change. Passing with the change:CallActivityTypeConversionTest(2),TypeConversionTest(3) andBoundaryTimerEventTest(25).