Repository navigation
[ci] release - #330
Merged
Merged
[ci] release#330
Conversation
✅ Deploy Preview for fulldev-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
fulldev-release
Bot
force-pushed
the
changeset-release/main
branch
3 times, most recently
from
October 24, 2026 21:58
5b8ddea to
ab3678b
Compare
silveltman
added a commit
that referenced
this pull request
Oct 26, 2026
Dialog, Sheet and NavigationMenu import their Data Slot controller statically and call `create()`, like the other Data Slot components, instead of loading it per media query (#331 to #333). - Removes the `onMedia` helper, `src/lib/dialog.ts`, the `on-media` registry item, the responsive activation docs and their tests. No custom loader, no loading props. - `media` stays accepted on the three components with no effect and is not rendered, so hosted-registry installs since #331 that pass it still type-check. - Header blocks 1 to 5 keep `fold="lg" | "xl"` and close the sheet or navigation menu the layout hides at that breakpoint, which releases the scroll lock. - Every Data Slot root script also binds on `astro:after-swap`, before a site's own `astro:page-load` listeners after ClientRouter navigation; published `create()` skips bound roots. - Published `@data-slot/*` ^1.1.2 and Liquid are unchanged. All eight styles regenerated. - Changeset: minor (removes a hosted registry item; folds into the pending 0.26.0 in #330). Sites that installed the hosted helpers can delete `src/lib/on-media.ts` and `src/lib/dialog.ts` once nothing imports them. Validation at `6f8b6aaed`: `vp run check` passes (988 files, 0 errors/warnings/hints; one existing knip configuration hint; registry matches). Unit 33/33. Build: 0 critical, 503 existing warnings, 357 hints. Browser 67/67 over Chromium, Firefox and WebKit, including all five headers at both folds (resize closing, scroll unlock, keyboard), ClientRouter teardown and a site page-load command after navigation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- codesmith:footer --> --- <a href="https://app.blacksmith.sh/fulldotdev/codesmith/ui/pr/334?autoLogin=true&ref=codesmith_pr_footer"><picture><source media="(prefers-color-scheme: dark)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-dark-v3.svg"><source media="(prefers-color-scheme: light)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-light-v3.svg"><img alt="View with [code]smith" src="https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-dark-v3-3x.png" width="162" height="28"></picture></a> <a href="https://backend.blacksmith.sh/track/enable-autofix?expires=1795605680&installation_model_id=442937&pr_number=334&ref=codesmith_pr_footer&repository=fulldotdev%2Fui&return_to=https%3A%2F%2Fgithub.com%2Ffulldotdev%2Fui%2Fpull%2F334&signature=d7fb5d0be6a73d145913bee3421c8644b601fbc9be00eeabc33a5c82851a02c3"><picture><source media="(prefers-color-scheme: dark)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-light.svg"><img alt="Autofix with [code]smith" src="https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark-3x.png" width="190" height="28"></picture></a> <sup>Need help on this PR? Tag <code>@codesmith-bot</code> with what you need.</sup> <!-- codesmith:autofix:disabled --> <!-- /codesmith:footer --> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
fulldev-release
Bot
force-pushed
the
changeset-release/main
branch
from
October 26, 2026 11:36
ab3678b to
b8357f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
![https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-dark-v3.svg"><source](https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-dark-v3.svg"><source){kind=link}
![https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-light-v3.svg"><img](https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-light-v3.svg"><img){kind=link}
![https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark.svg"><source](https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark.svg"><source){kind=link}
![https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-light.svg"><img](https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-light.svg"><img){kind=link}
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
fulldev-ui@0.26.0
Minor Changes
#328
53e43a0Thanks @silveltman! - Add an optional Image component with Astro Picture formats, responsive sources and an unchanged single-image default.#334
6ed056fThanks @silveltman! - Data Slot components start with their page script, with no loading helper. Dialog, Sheet and NavigationMenu no longer load their controller per media query:mediais still accepted but has no effect, and the registry no longer has theon-mediaitem orsrc/lib/dialog.ts; a site that installed them can deletesrc/lib/on-media.tsandsrc/lib/dialog.tsonce nothing imports them. Header blocks 1 to 5 takefold="lg", the default, orfold="xl"for the breakpoint between their mobile sheet and desktop navigation, and close whichever one the layout hides at that breakpoint, which also releases the sheet's scroll lock. Every Data Slot component also binds new roots onastro:after-swap, so a site's ownastro:page-loadcommand after ClientRouter navigation reaches a started controller.