Skip to content

generator: Avoid copying quickstart list results #16607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Amanpal9 wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −2
Open

generator: Avoid copying quickstart list results #16607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ff34b9
generator: Avoid copying quickstart list results
Amanpal9 Oct 30, 2026
4d39958
generator: avoid moving from const list result
Amanpal9 Oct 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions generator/internal/scaffold_generator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -983,8 +983,8 @@ int main(int argc, char* argv[]) try {
auto client = $library$::ServiceClient(
$library$::MakeServiceConnection()); // EDIT HERE

for (auto r : client.List/*EDIT HERE*/(location.FullName())) {
if (!r) throw std::move(r).status();
for (auto const& r : client.List/*EDIT HERE*/(location.FullName())) {

@gemini-code-assist gemini-code-assist Bot Oct 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Changing r to auto const& means that std::move(r) on the next line (line 987) is now redundant and misleading, as you cannot move from a const reference. It will silently fall back to a copy. Consider removing std::move and calling r.status() directly.

if (!r) throw r.status();
std::cout << r->DebugString() << "\n";
}

Expand Down
1 change: 1 addition & 0 deletions generator/internal/scaffold_generator_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,7 @@ TEST_F(ScaffoldGenerator, QuickstartSkeleton) {
auto const actual = std::move(os).str();
EXPECT_THAT(actual, HasSubstr("2034"));
EXPECT_THAT(actual, Not(HasSubstr("$copyright_year$")));
EXPECT_THAT(actual, HasSubstr("for (auto const& r : client.List"));
}

TEST_F(ScaffoldGenerator, QuickstartCMake) {
Expand Down
Loading