Repository navigation
NetBSD has explicit_memset(), not explicit_bzero() - #5
Merged
Merged
Conversation
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an assumption in the code that NetBSD, like the other major BSD variants, has an implementation of explicit_bzero() in its standard library. This is incorrect; NetBSD has explicit_memset() (with memset_explicit() as an alias), as a more general function.
This patch adds support for explicit_memset(), using ifdef to support EXPLICIT_MEMSET the same way EXPLICIT_BZERO is already supported, and defaulting to enabling it on NetBSD. At the same time, the erroneous default enabling of the use of explicit_bzero() on NetBSD is removed.