Repository navigation
Webui fixes - #1761
Draft
mattiaswal wants to merge 5 commits into
Draft
Webui fixes#1761mattiaswal wants to merge 5 commits into
mattiaswal wants to merge 5 commits into
Conversation
The IEEE 802.3 frame counters were left behind when yangerd took over operational data, and a counter is read now and then, not watched. A get-statistics action on the Ethernet container reads them from the port with ethtool when called, in a new revision of infix-ethernet-interface that deviates the statistics container out. `show interface <port>` and the WebUI interface page run it. Signed-off-by: Mattias Walström <lazzer@gmail.com>
Each refresh rebuilt the whole content area, which flickered and lost the scroll position, selection and focus. With idiomorph (0BSD) the fetched page is diffed against the DOM and only changed values are touched; the counters card morphs the same way. Signed-off-by: Mattias Walström <lazzer@gmail.com>
The refreshed page comes without them, so they vanished on the next tick. Preserve the result containers like the locate result. Signed-off-by: Mattias Walström <lazzer@gmail.com>
The interface detail page does not auto-refresh, only its counters card polls, so the frame counters never moved. The card is now part of the polled fragment, read every 5 s like the other counters. Signed-off-by: Mattias Walström <lazzer@gmail.com>
Only its counters card polled, the link state, addresses and WiFi stations stayed as they were when the page opened. Follow the refresh interval like the modem and GPS pages. Signed-off-by: Mattias Walström <lazzer@gmail.com>
Contributor
|
Before I review this, would be nice with an overview/description of the PR. |
Contributor
Author
Mmm its not done yet |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Tick relevant boxes, this PR is-a or has-a: