Skip to content

feat: unhide server-side evaluation commands and --server-side flag - #1318

Merged
ToreMerkely merged 2 commits into
mainfrom
unhide-server-side-evaluation
Oct 30, 2026
Merged

ToreMerkely merged 2 commits into
mainfrom
unhide-server-side-evaluation

Conversation

@ToreMerkely

Copy link
Copy Markdown
Contributor

Unhides kosli evaluate policy, publish/list/get rego-policy and --server-side on evaluate trail/trails as beta, now that the server gates them on the controls flag. Keeps the deprecated --policy alias.

See kosli-dev/server#7658

🤖 Generated with Claude Code

kosli evaluate policy, publish/list/get rego-policy and --server-side on
evaluate trail/trails are now public as beta, now that the server gates
them on the controls feature flag. See kosli-dev/server#7658

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ToreMerkely
ToreMerkely enabled auto-merge (squash) October 30, 2026 10:23
@github-actions github-actions Bot added go Pull requests that update go code feat labels Oct 30, 2026
@claude

claude Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @ToreMerkely's task in 33s —— View job


Follow-up review complete

  • Fetch previous review comments and new commit diff
  • Check status of each previous finding
  • Review new commits for bugs/regressions introduced by the fix
  • Post summary

Diff reviewed: e6768088..524a6b11 (2 files changed: cmd/kosli/root.go, cmd/kosli/publishRegoPolicy_test.go)

Previous findings:

  1. root.go — serverSideFlag help text should explain what --server-side can't be combined with → Resolved. The constant now reads "[optional] Evaluate the policy on the Kosli server rather than on this machine. Cannot be combined with --attestations, --show-input or --output-rule.", matching the suggested wording exactly.
  2. publishRegoPolicy_test.go — TestItIsListedInHelp assertion on combined, "publish" is too weak → Resolved. The test now asserts require.Contains(suite.T(), combined, publishDesc), which matches the precise listing text (publishDesc is defined in publish.go and used for both Short/Long).

No new issues found — both changes are minimal, non-functional (string/test-assertion only) edits with no regression risk.

Comment thread cmd/kosli/root.go Resolved
Comment thread cmd/kosli/publishRegoPolicy_test.go Resolved
…ish help test

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ToreMerkely
ToreMerkely merged commit 05efa38 into main Oct 30, 2026
22 checks passed
@ToreMerkely
ToreMerkely deleted the unhide-server-side-evaluation branch October 30, 2026 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat go Pull requests that update go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants