Repository navigation
Conversation
TestPermissionHookBuiltBinary moved HOME to a temporary directory before
running go build. With GOPATH unset, go then downloaded every module into a
cache under that HOME, whose files are read-only, so the test failed at
cleanup ("TempDir RemoveAll cleanup: unlinkat ... permission denied") on
any machine without GOMODCACHE set, and took 25 seconds. CI sets the cache
paths, so it passed there.
The build now uses the module and build caches go reports before HOME
moves. The test passes locally in about 3 seconds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestPermissionHookBuiltBinary moved HOME to a temporary directory before
running go build. With GOPATH unset, go then downloaded every module into a
cache under that HOME, whose files are read-only, so the test failed at
cleanup ("TempDir RemoveAll cleanup: unlinkat ... permission denied") on
any machine without GOMODCACHE set, and took 25 seconds. CI sets the cache
paths, so it passed there.
The build now uses the module and build caches go reports before HOME
moves. The test passes locally in about 3 seconds.