Repository navigation
Conversation
This reverts commit e5c4624.
markm39
changed the title
markm39
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenNotes 1.3.7 improves writing and zooming, image and ink layering, light and dark appearance, tool sizes, return to pen, custom covers, and the compact folder library. An optional, dismissible library invitation links to MathNotes without sending note content or an identifier.
The release uses the Mobile Ink engine from the iPad-tested build 34 plus the lasso fix in Mobile Ink 0.3.11. Existing notes without historical image and ink ordering retain their legacy ordering; older app versions can discard newer ordering metadata when rewriting a note.
TypeScript and the existing app tests passed. The GitHub iPad interaction suite passed, including the MathNotes invitation, cross-page assets and export. The responsiveness audit failed its 100 ms budget; the dense page/keyboard workload recorded a maximum main-thread delay of 2,042.54 ms, and the pan/zoom and writing workloads also exceeded the budget. The follow-up profile sampled substantial XCTest accessibility-query work on the main thread; it does not prove that every measured stall is test overhead. A separate page-divider experiment also missed the overall budget. OpenNotes 1.3.7 build 40 is valid and in internal TestFlight; it has not been submitted for App Store review.
The existing library screen and native interaction test file exceed 500 lines; splitting their shared navigation and test fixtures in this release would broaden the behavioral change. The invitation itself is a separate component.
The latest settled-host run passed the native interaction suite but failed its responsiveness gate: Pages/keyboard reached 1,230 ms, pan/zoom render p95 was 19.38 ms (budget 16.7 ms), and writing reached 100.13 ms (budget 100 ms). Audit run. Diagnostic profiling is in progress.
App Store Connect version 1.3.7 now has processed build 40 selected with release after approval; it is still in Prepare for Submission and has not been submitted.