Skip to content

Keep the Friday traffic run green when it cannot open the weekly PR - #577

Merged
Alejandro Lopez (soyalejolopez) merged 1 commit into
microsoft:masterfrom
soyalejolopez:soyalejolopez-weekly-traffic-warning
Oct 30, 2026
Merged

Alejandro Lopez (soyalejolopez) merged 1 commit into
microsoft:masterfrom
soyalejolopez:soyalejolopez-weekly-traffic-warning

Conversation

@soyalejolopez

Copy link
Copy Markdown
Member

Category

  • New resource (script, agent, guide, analytics, skill)
  • Update to an existing resource
  • Bug fix
  • Docs, site, or tooling

What's in this pull request?

Stops the Friday run of Collect Traffic Data from going red every week. Under the organization policy, Actions cannot open pull requests, so the weekly publish step failed on purpose after staging the data safely (run 216 on 2026-10-30). A failure that happens every Friday and needs no repair trains people to ignore red runs.

What changed

  • traffic-stats.yml: when AUTOMATION_PAT is not configured (the known policy), the weekly step now writes a ::warning:: and a run summary with the compare link, then exits 0. It still updates the existing weekly PR when one is open. If a configured token cannot create the PR, that is unexpected and still fails the run through the existing "Fail when weekly PR preparation was blocked" step.
  • test-traffic-workflow.js: asserts the no-token branch warns with the compare link and cannot fail, and that the configured-token failure path still fails.
  • traffic-data/README.md and CHANGELOG.md: describe the new behavior and the Friday manual step (open the PR, confirm it changes only resource-stats.json and traffic-data/clarity-views.json, merge).

Still manual: someone opens the weekly PR each Friday from the compare link in the run summary. The Housekeeping email already lists it as a chore.

Verified: npm run check passes. I also ran the extracted step script with a stubbed gh and no token: it printed the warning, wrote the summary, and exited 0.

Related issues

Follows #572.

Checklist

  • No private, customer-specific, or unlicensed content, and no secrets
  • README front matter is valid: npm ci --prefix tools/catalog-build && npm run check --prefix tools/catalog-build (passes)
  • version and updated were bumped (not applicable: no resource changed)
  • Installation and usage steps were tested
  • Files over 5 MB were avoided

See CONTRIBUTING.md for details.

Under the organization policy Actions cannot open pull requests, so the Friday publish step failed every week even though the data was staged safely. Without AUTOMATION_PAT it now emits a warning and a run summary with the compare link and exits 0. A configured token that still cannot create the pull request keeps failing the run.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@soyalejolopez
Alejandro Lopez (soyalejolopez) merged commit 573c1e3 into microsoft:master Oct 30, 2026
5 checks passed
@soyalejolopez
Alejandro Lopez (soyalejolopez) deleted the soyalejolopez-weekly-traffic-warning branch October 30, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants