Skip to content

fix(tsoptions): don't panic on empty files when AST node is missing #65082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Timur Vural (timurzvural) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(tsoptions): don't panic on empty files when AST node is missing #65082

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tsc/internal/tsoptions/tsconfigparsing.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1220,7 +1220,10 @@ func parseJsonConfigFileContentWorker(
}
diagnosticMessage := diagnostics.The_files_list_in_config_file_0_is_empty
nodeValue := ForEachTsConfigPropArray(sourceFile.SourceFile, "files", func(property *ast.PropertyAssignment) *ast.Node { return property.Initializer })
errors = append(errors, CreateDiagnosticForNodeInSourceFile(sourceFile.SourceFile, nodeValue, diagnosticMessage, fileName))
// Prefer a node-anchored diagnostic when the "files" property is present in the AST;
// under parse recovery the raw value can still be an empty array while the property
// node is missing, so fall back to a compiler diagnostic (matches Strada).
errors = append(errors, CreateDiagnosticForNodeInSourceFileOrCompilerDiagnostic(sourceFile.SourceFile, nodeValue, diagnosticMessage, fileName))
} else {
errors = append(errors, ast.NewCompilerDiagnostic(diagnostics.The_files_list_in_config_file_0_is_empty, configFileName))
}
Expand Down