Repository navigation
[PHP-8.4] Backports for OpenSSL 4.1 - #25140
Open
thesamesam wants to merge 2 commits into
Open
thesamesam wants to merge 2 commits into
thesamesam wants to merge 2 commits into
Conversation
thesamesam
changed the title
thesamesam
force-pushed
the
PHP-8.4-openssl-4
branch
4 times, most recently
from
November 1, 2026 23:26
7e4d437 to
c1b606d
Compare
Member
|
CI failure is related. |
thesamesam
marked this pull request as draft
November 2, 2026 06:31
thesamesam
force-pushed
the
PHP-8.4-openssl-4
branch
2 times, most recently
from
November 3, 2026 03:03
444c1df to
03612e2
Compare
thesamesam
marked this pull request as ready for review
November 3, 2026 03:13
* Fix OpenSSL 4 test compatibility * Fix OpenSSL 4 build compatibility * Use OpenSSL 4 in macOS CI * Fix OpenSSL 1.1 build compatibility * Preserve raw CN matching with OpenSSL 4 (cherry picked from commit 6aca6e3)
OpenSSL 4.1 deprecates ASN1_STRING_set() and ASN1_STRING_length(). use ASN1_STRING_set1_data() and ASN1_STRING_get_length() instead as recommended in official doc https://docs.openssl.org/4.1/man7/ossl-guide-migration/#asn1_string-values-have-never-been-nul-byte-terminated (cherry picked from commit 3678f39)
thesamesam
force-pushed
the
PHP-8.4-openssl-4
branch
from
November 3, 2026 03:56
03612e2 to
6a44431
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This passes the testsuite but I haven't done any further testing for it. Please give the
php_openssl_matches_common_namechanges in the first commit a careful look. The rest applied pretty cleanly from PHP-8.6.See also #25139.