Repository navigation
Add XML options to Prettier's Options type - #1060
Draft
ungaaaabungaaa wants to merge 1 commit into
Draft
ungaaaabungaaa wants to merge 1 commit into
ungaaaabungaaa wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #981. Thanks to @gtbuchanan for reporting the missing XML option types.
Importing the plugin now augments Prettier's
Optionswith all four XML options and their valid values. Add a typed configuration example and a compiler regression test to the existing Jest suite. Formatter runtime files are unchanged.Validation: the new test fails before the declaration change. Afterwards all 18tests / 11snapshots pass on Node 24.18.0; lint and formatting pass. All 18tests / 11snapshots also pass on Node 20.20.2 using the dependencies installed under Node 24. The packed plugin's types pass with Prettier 3.0.0 and 3.9.10, including invalid-value rejection and exact optional properties.
Draft / CI setup blocker:
.github/workflows/main.ymlselects Node 20, while the existing lockedlint-staged@17.6.0requires Node ≥22.22.1. A fresh frozen install fails on both this change and the unmodified baseb252a6b. No engine check was bypassed and the workflow was not changed. Maintainer guidance or a compatible CI environment is needed before treating the PR as fully green.Prepared with OpenAI Codex assistance, including code, tests, and this description.
Captured local validation report
This is a rendered report of captured local output, including the setup limitation. Evidence files are on a separate fork branch and are excluded from this PR.