Skip to content

gh-161187: Fix unused variable compiler warning in marshal.c - #161188

Merged
sobolevn merged 1 commit into
python:mainfrom
sobolevn:issue-161187
Nov 2, 2026
Merged

sobolevn merged 1 commit into
python:mainfrom
sobolevn:issue-161187

Conversation

@sobolevn

@sobolevn sobolevn commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

@sobolevn
sobolevn requested review from gpshead and vstinner November 2, 2026 14:52
@sobolevn sobolevn added skip news needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Nov 2, 2026
@vstinner vstinner changed the title gh-161187: Fix unsued variable compiler warning in marshal.c gh-161187: Fix unused variable compiler warning in marshal.c Nov 2, 2026

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

There is just a typo in the PR title: "Fix unsued variable" => "Fix unused variable". (I changed the PR title.)

I noticed that the warning is also on the main branch, after I reviewed your #153413 change.

@sobolevn

sobolevn commented Nov 2, 2026

Copy link
Copy Markdown
Member Author

Technically this variable is also unsued 😅
Thanks for your help!

@sobolevn
sobolevn enabled auto-merge (squash) November 2, 2026 15:22
@vstinner vstinner removed needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Nov 2, 2026
@vstinner

vstinner commented Nov 2, 2026

Copy link
Copy Markdown
Member

I removed labels to backport to 3.14 and 3.15 branches.

3.14 and 3.15 branches don't emit a compiler warning in Python/marshal.c. So this issue is specific to the main branch. Correct me if I'm wrong.

@sobolevn
sobolevn merged commit 2ef3728 into python:main Nov 2, 2026
69 checks passed
@vstinner

vstinner commented Nov 2, 2026

Copy link
Copy Markdown
Member

3.14 and 3.15 branches don't have the new w_tie_set_items() function in Python/marshal.c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants