Repository navigation
Fix SimpleReader traversal adapters - #339
Open
Zhuyuyangyy wants to merge 1 commit into
Open
Zhuyuyangyy wants to merge 1 commit into
Zhuyuyangyy wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A provider implementing the documented
SimpleReaderinterface throughTraversableReadercannot usefiles():ResourceContaineris still abstract because it does not implementTraversable.name.The same adapter path has further blockers once the container can be instantiated:
ResourceHandlelacks concretenameanditerdirimplementations, resource enumeration iterates over theresourcesmethod rather than its result, and the leaf'sjoinpathcannot accept the empty tail supplied byTraversable.joinpath.Changes
resources()when enumerating entries.joinpath()return itself while preserving the existing error for attempts to traverse further.simple.pyin coverage and add a news fragment.The change is confined to the SimpleReader adapters; it does not alter the public Traversable base implementation.
Validation
tox -e py312: 312 passed, 1 skipped, 81 subtests passed, including Ruff and mypy checks (no issues in 30 source files).simple.py: 59/59 statements covered (100%); overall suite coverage 97%.ruff format --check importlib_resources/simple.py importlib_resources/tests/test_simple.py: passed.git diff --check: passed.Checked the existing open PRs and related history (#183, #249, #250, #267); I did not find an existing fix for this adapter failure.
AI assistance disclosure
This PR was prepared by an AI coding agent acting on behalf of @Zhuyuyangyy, including the code, regression tests, and automated validation. It has not received independent human code review.