Repository navigation
docs: Fix missing NavigationContainer imports in multiple drawers examples - #1526
Open
developerdanx wants to merge 1 commit into
Open
developerdanx wants to merge 1 commit into
developerdanx wants to merge 1 commit into
Conversation
✅ Deploy Preview for react-navigation-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The first two multiple-drawers examples in the 6.x documentation render
NavigationContainerwithout importing it. Copying either example results in an undefined component.Add the missing import from
@react-navigation/nativeto both examples. The other two examples already import it; 7.x and 8.x use the static navigation API and need no changes.Fixes #1292
Validation
NavigationContainerimport it from@react-navigation/native.git diff --checkand reverse applicability check of the exported patch.