Repository navigation
docs: Use headerTitle for Redux header components - #1527
Open
developerdanx wants to merge 1 commit into
Open
developerdanx wants to merge 1 commit into
developerdanx wants to merge 1 commit into
Conversation
✅ Deploy Preview for react-navigation-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Redux integration guide passes a component renderer to
title, which accepts a string. UseheaderTitlefor the renderer and update the accompanying explanation in both affected versions (5.x and 6.x). String-valued titles remain unchanged.Fixes #1370
Validation
headerTitle, the explanation matches it, and the route-param string title is preserved.git diff --checkpasses.