[javache]

Summary:

Summary

Fixes #2052.

Replacing a non-integer size with max-content, fit-content, or stretch could make the getter return a different keyword. YGNodeStyleSetHeight(node, 0.5f), then YGNodeStyleSetWidth(node, 0.25f), then YGNodeStyleSetWidthMaxContent(node) made YGNodeStyleGetWidth return YGUnitFitContent instead of YGUnitMaxContent.

A non-integer size is stored in the value pool, and the handle keeps that pool index in its value bits. storeKeyword changed the type to Keyword but left the indexed bit set, so isKeyword compared the pool index with the keyword enum (MaxContent = 0, FitContent = 1, Stretch = 2). The same mismatch affects height, min and max size, and flex-basis. A pool index of 3 or more matches no keyword and hits the debug assert in getSize.

auto, undefined, margin, and padding read the type bits only, so those getters were already correct. storeKeyword still writes the keyword into the handle's existing pool slot. getSize now reads that slot when the indexed bit is set, so the handle keeps the slot and the getter returns the stored keyword.

Test plan

• YogaTest.width_keyword_replaces_pooled_number covers the [ScrollView] Why the top of ScrollView has more than 20 pixels #2052 sequence.
• StyleValuePool.store_keywords_after_large_int checks max-content, fit-content, and stretch in pool slots 0 through 3.
• StyleValuePool.store_large_int_and_keyword_repeatedly switches a pooled number and max-content 5000 times and checks that the slot is reused.
• ./unit_tests Debug: 880 passed, 0 failed. Baseline before these tests was 877 passed, 0 failed.

Changelog:
[General][Fixed] - Fix reading back max-content, fit-content, and stretch after a non-integer size was stored

Reviewed By: javache

Differential Revision: D128898045

[meta-codesync]

@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D128898045.