Repository navigation
Conversation
Contributor
Author
|
Addressed the CI snapshot failure by regenerating the four affected Apple API snapshots with the official |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #59730.
Complete WebSocket-provider and RedBox header nullability annotations while preserving existing nil fallbacks and optional inputs. Match NSObject's nullable
isEqual:parameter inRCTReactTaggedView.The existing legacy
RCTRootViewcustomization declaration gets declaration-local deprecation handling, without changing its signature or suppressing consumer warnings. Addscripts/test-ios-swift-headers.sh, an unsigned generic-simulator smoke build usingSWIFT_TREAT_WARNINGS_AS_ERRORS=YES.Changelog
[IOS] [FIXED] - Fix React Native header warnings that prevent Swift module imports when warnings are treated as errors
Test Plan
Reproduced both reported
SwiftExplicitDependencyGeneratePcmfailures on Xcode 27.1 with the issue's pinned0.89.0-nightly-20261031-e57dcb3ccreproducer. All six affected baseline headers were byte-identical to this branch's base before staging fixes.RCT_TESTONLY_RNCORE_TARBALL_PATH. Both architectures and module imports passed; the framework binary remained byte-identical.RCTRootViewstill emits the expected error, confirming the pragma does not suppress downstream warnings.yarn cxx-api-buildand Doxygen 1.16.1; all 12 snapshots pass CI-style validation. The final source smoke also recompilesRCTRedBox.mmwithout a nonnull warning for its intentional nil reload-controller argument.git diff --checkpass.These are actual app/compiler builds, not regex checks. Validation stages equivalent current headers into the pinned nightly; it is not a whole-checkout HEAD build or newly built precompiled XCFramework. No runtime/UI tests, complete repository suite, Release/Catalyst/device build, or public CI result is claimed. The new smoke script is not wired into CI in this patch.