Skip to content

Add hermes-eslint dependency to @react-native/eslint-config - #59755

Open
lazerg wants to merge 1 commit into
react:mainfrom
lazerg:fix/issue-59749-hermes-eslint-peer
Open

lazerg wants to merge 1 commit into
react:mainfrom
lazerg:fix/issue-59749-hermes-eslint-peer

Conversation

@lazerg

@lazerg lazerg commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Summary:

eslint-plugin-ft-flow 3.x declares hermes-eslint as a required peer dependency, but @react-native/eslint-config never provided it, so installing an app on main warns about an unmet peer. This adds hermes-eslint to the config's dependencies.

Fixes #59749

Changelog:

[GENERAL] [FIXED] - Add missing hermes-eslint dependency to @react-native/eslint-config to satisfy the eslint-plugin-ft-flow peer dependency

Test Plan:

yarn install --frozen-lockfile succeeds with the updated yarn.lock, and hermes-eslint@0.25.1 resolves to the same hermes-parser/hermes-estree versions already in the lockfile.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 2, 2026
@facebook-github-tools facebook-github-tools Bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Nov 2, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@react-native/eslint-config on main leaves eslint-plugin-ft-flow's required hermes-eslint peer dependency unmet

1 participant