Repository navigation
Recognize amend aliases on macOS - #904
Merged
Merged
Conversation
macOS git's regex library does not support `\s`, so `git config --get-regexp` never matched an alias for `commit --amend` and amendment? returned false. Use the POSIX `[[:space:]]` class, which both git and Ruby understand. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wo4FerFK9aaxrGrmVE9ncZ
apiology
marked this pull request as ready for review
October 21, 2026 20:57
Owner
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude: This PR was written by Claude Code on behalf of @apiology.
Problem
On macOS, amending through a git alias isn't recognized as an amend:
Hooks that treat amends specially (e.g. including the previous commit's changes) misbehave for macOS users who amend via an alias, and the four
#amendment?alias specs fail there.Solution
Spell the pattern with the POSIX
[[:space:]]class, which macOS git, Linux git and Ruby's regex engine all understand.