Repository navigation
refactor: move subqueue context handling from AbstractQueue to Subqueue - #31
Merged
Merged
Conversation
rybakit
force-pushed
the
refactor/move-subqueue-context-to-subqueue
branch
5 times, most recently
from
October 29, 2026 23:47
9641c74 to
7ee821b
Compare
Remove the generic context machinery ($context property, callWithContext(), withContext()) from AbstractQueue and make Subqueue explicitly manage its own subqueue parameter routing per method. This makes AbstractQueue simpler and context-free, while Subqueue becomes self-contained with explicit per-method parameter passing that matches the Tarantool subqueuettl Lua driver contract: - put/release: merge subqueue opts into the options array - take/touch/ack/peek/bury/kick/delete/truncate: append subqueue opts as a trailing argument
rybakit
force-pushed
the
refactor/move-subqueue-context-to-subqueue
branch
from
October 29, 2026 23:50
7ee821b to
8175cf0
Compare
rybakit
marked this pull request as ready for review
October 29, 2026 23:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move subqueue-specific context handling out of
AbstractQueueand intoSubqueue, making the base class simpler and the subqueue parameter routing explicit.Changes
AbstractQueueprotected array $contextpropertycallWithContext()— methods now delegate directly tocall()withContext()— no longer needed without the context propertytake(),touch(), andtruncate()simplified from manual$argsarray building + conditional context append to plaincall()delegationSubqueue$subqueueNameas a plain string instead of setting$contextsubqueuettlLua driver contract:put/release: merge['subqueue' => $name]into the options arraytake/touch/ack/peek/bury/kick/delete/truncate: append['subqueue' => $name]as a trailing argumentTests
Subqueuemethod