Repository navigation
test(shared): remove duplicate devEngines parse tests - #3301
Merged
fengmk2 merged 2 commits intoNov 1, 2026
Merged
Conversation
Three `vp_shared::package_json` tests repeat a case that a stronger test in the same module already checks with the same assertions: - `test_malformed_single_entry_parses_as_absent` (`"runtime": "node@24"`) is one row of `test_parse_field_non_object_values`. - `test_malformed_dev_engines_does_not_break_engines_parse` (a string `devEngines` next to `engines.node`) is the `"text"` row of `test_parse_dev_engines_non_object_values`. - `test_parse_engines_node` is the `engines` half of `test_parse_both_engines_and_dev_engines`. Each product mutation that failed a removed test also failed the covering test, and still does after the removal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PxVsmvB9xfZKfVnUonY8kf
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://claude-prune-tests-duplicate-dev-engines-parse-tes-viteplus-dev.voidzero-docs.workers.dev (commit 833d32f)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
Contributor
CLI artifact sizes (
|
| Artifact | Format | Base | PR | Change |
|---|---|---|---|---|
packages/cli/dist |
Directory total | 2.27 MiB | 2.27 MiB | 0 B (0.00%) |
packages/core/dist |
Directory total | 4.07 MiB | 4.07 MiB | 0 B (0.00%) |
| Combined package dist | Directory total | 6.34 MiB | 6.34 MiB | 0 B (0.00%) |
vp (Linux x64) |
Binary | 8.26 MiB | 8.26 MiB | 0 B (0.00%) |
vp (Linux x64) |
gzip -9 | 3.77 MiB | 3.77 MiB | 0 B (0.00%) |
| NAPI (Linux x64) | Binary | 35.56 MiB | 35.56 MiB | 0 B (0.00%) |
| NAPI (Linux x64) | gzip -9 | 14.17 MiB | 14.17 MiB | 0 B (0.00%) |
vp (macOS ARM64) |
Binary | 5.39 MiB | 5.39 MiB | 0 B (0.00%) |
vp (macOS ARM64) |
gzip -9 | 3.21 MiB | 3.21 MiB | 0 B (0.00%) |
| NAPI (macOS ARM64) | Binary | 42.31 MiB | 42.31 MiB | 0 B (0.00%) |
| NAPI (macOS ARM64) | gzip -9 | 18.31 MiB | 18.31 MiB | 0 B (0.00%) |
vp (Windows x64) |
Binary | 6.12 MiB | 6.12 MiB | 0 B (0.00%) |
vp (Windows x64) |
gzip -9 | 2.83 MiB | 2.83 MiB | 0 B (0.00%) |
| NAPI (Windows x64) | Binary | 31.58 MiB | 31.58 MiB | 0 B (0.00%) |
| NAPI (Windows x64) | gzip -9 | 12.86 MiB | 12.86 MiB | -1 B (-0.00%) |
| Trampoline (Windows x64) | Binary | 13.50 KiB | 13.50 KiB | 0 B (0.00%) |
| Trampoline (Windows x64) | gzip -9 | 7.09 KiB | 7.09 KiB | 0 B (0.00%) |
| Installer (Windows x64) | Binary | 4.65 MiB | 4.65 MiB | 0 B (0.00%) |
| Installer (Windows x64) | gzip -9 | 2.23 MiB | 2.23 MiB | 0 B (0.00%) |
fengmk2
approved these changes
Nov 1, 2026
fengmk2
deleted the
claude/prune-tests-duplicate-dev-engines-parse-tests
branch
November 1, 2026 15:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Brooklyn · project thread
Before: three tests in
vp_shared::package_jsoneach repeated one case of a stronger table-style test in the same module, with the same assertions, so they could only fail together with it.After: the three tests are gone. Every product mutation that failed one of them also fails its covering test, before and after the removal. Only
#[cfg(test)] mod testschanges.Totals
vp_sharedunit cases (plus 6 doctests, unchanged); after: 132. The workspace-wide count could not be collected (see below).<0.000s>).Removals
test_malformed_single_entry_parses_as_absent: its input"runtime": "node@24"and assertionruntime.is_none()are the"\"node@24\""row oftest_parse_field_non_object_values. M1 (accept a bare string as a single entry's name) failed both; after the removal it still failstest_parse_field_non_object_values.test_malformed_dev_engines_does_not_break_engines_parse: a stringdevEnginesnext toengines.node, with three assertions;test_parse_dev_engines_non_object_valuesmakes the same three for its"\"text\""row (and seven more shapes). M2 (reject a stringdevEngines) failed both; after, it still fails the covering test.test_parse_engines_node:{"engines":{"node":">=20.0.0"}}with one assertion, theengineshalf oftest_parse_both_engines_and_dev_engines(enginesanddevEnginesare independent serde fields). M3 (#[serde(default, rename = "engine")]onengines) failed it and 4 others; after, it still failstest_parse_both_engines_and_dev_engines,test_parse_dev_engines_non_object_valuesandtest_parse_engines_node_empty.Kept after defense: none; every nominee had another test failing on its mutation.
Case counts
crates/vp_shared/src/package_json.rsvp_sharedunit total0 failures before and after.
What ran and what did not
4928bc57and on this branch:cargo test -p vp_shared -- -Z unstable-options --report-time; the three mutations (each reverted);cargo clippy -p vp_shared --all-targets --all-features -- --deny warnings;cargo fmt --all -- --check;git diff --check. All clean.just init(which clones rolldown),packages/cli/bindingwas dropped from the workspace members locally;Cargo.tomlandCargo.lockwere restored and are not in this PR.just check/just test/just lint(they need the rolldown clone), other crates, Windows, the JS suite and the snapshot suites. No other file changes.Open pull requests: none of the 62 open PRs touches this file. Ages:
test_parse_engines_nodefrom #522 (2026-02-07), the other two from #1760 (2026-06-08); none was added for a bug or sits in a permission or security suite.To revert:
git revert 261d71b3.Generated by Claude Code