Repository navigation
Conversation
wan9chi
force-pushed
the
fix/cache-dist-in-listings
branch
from
October 30, 2026 03:19
7df8d21 to
0d60891
Compare
fspy benchmarklinuxmacoswindows |
wan9chi
force-pushed
the
fix/cache-dist-in-listings
branch
from
October 30, 2026 04:06
0d60891 to
dbd1644
Compare
wan9chi
force-pushed
the
fix/cache-dist-in-listings
branch
from
October 30, 2026 06:31
dbd1644 to
4e828d2
Compare
wan9chi
force-pushed
the
fix/cache-dist-in-listings
branch
from
October 30, 2026 07:08
4e828d2 to
992cd6a
Compare
…unseen Two cases for a task that lists a folder in which a `dist` folder it didn't write appears later. In `dist_appears_in_listed_folder`, the task lists the package root with `vtt list-dir .` and prints its entries. In `oxlint_dist`, `oxlint -D no-debugger` lints a package whose `.gitignore` lists `node_modules` but not `dist/`, like a GitHub Action that commits its built `dist/`: it lists the package root, `src` and, once there, `dist`, and reads the files in them. Today every listing skips an entry named `dist`, so a new `dist` folder in the listed root goes unseen and the next run is a cache hit: the first case replays the old listing without `dist`, and the second passes although `dist/bad.js` holds a `debugger` statement. The oxlint fixture ignores `node_modules` as a real package would; otherwise oxlint walks into vp's task cache in `node_modules/.vite`, whose files change between runs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Every directory listing fingerprint skipped an entry named `dist`, a workaround so that a tool listing the folder holding its own `dist` output folder didn't miss on a clean checkout. It helped no other folder name and hid a `dist` that does matter: a `dist` folder appearing in or disappearing from a folder the task listed went unseen, and the next run was a cache hit replaying stale output, like `oxlint` passing after a `dist` folder with lint errors appeared in a package that commits its built `dist/`. Listings now skip only `.`, `..` and `.DS_Store`. A task's own `dist` output folder doesn't need the skip anymore: a folder holding only what the task can rebuild is an ignored entry of the listing, so it may be missing. No other snapshot changes, including `typescript_out_dir` and `astro_empty_collections`, whose tasks list the folder holding their own `dist`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
wan9chi
force-pushed
the
fix/cache-dist-in-listings
branch
from
November 1, 2026 11:55
992cd6a to
5b6b3b8
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Every directory listing skips an entry named
dist, a workaround so that a tool listing the folder holding its owndistdoesn't miss on a clean checkout. It helps no other folder name and hides adistthat does matter. Adistfolder appearing in a folder the task listed goes unseen, and the next run replays stale output:oxlint, for example, passes from the cache after adistfolder with lint errors appears.Changes
Listings skip only
.,..and.DS_Store. A task's owndistdoesn't need the skip anymore, since #915 makes a rebuildable folder an ignored entry. No other snapshot changes.E2E cases:
dist_appears_in_listed_folder(synthetic,vtt list-dir) andoxlint_dist(oxlint -D no-debugger). Both are false hits today and correct misses after.Part of a stack that lets automatic tracking cache tasks which read their own outputs and list the folders holding them, so they also hit on a clean checkout.
🤖 Generated with Claude Code
Note
Medium Risk
Touches cache input fingerprinting for all tasks that list directories; behavior change is intentional but could shift hit/miss rates for workflows that relied on ignoring unrelated
distfolders.Overview
Directory listings used to drop every entry named
dist, so adistfolder that appeared or vanished in a listed directory never changed the cache fingerprint and the next run could replay stale cached output (e.g.oxlintstill passing afterdist/bad.jsshowed up).should_ignore_entryin post-run fingerprinting now skips only.,.., and.DS_Store. Adistthe task itself wrote is still excluded from listings via the existing rebuildable-entry logic from #915, not a hard-coded name.E2E snapshots
dist_appears_in_listed_folderandoxlint_distlock in a cache miss when an externaldistappears.Reviewed by Cursor Bugbot for commit 5b6b3b8. Bugbot is set up for automated code reviews on this repo. Configure here.