Repository navigation
Preserve custom acontainer factory return types - #72
Open
ShahadatTest wants to merge 1 commit into
Open
ShahadatTest wants to merge 1 commit into
ShahadatTest wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
acontainer()accepts arbitrary collection factories at runtime, but its three overloads reject frozenset and custom functions. Add a generic factory overload that retains the concrete return type. The regression test checks both runtime results and inferred types for frozenset[int] and a summary dict. Built-in tuple/list/set overloads remain first and keep their existing precision.Before: basedpyright rejects both supported custom-container calls (8 diagnostics). After: whole-project mypy and basedpyright pass; pyrefly reports 0 errors. Python 3.10/3.12: 429 passed, 5 IANA-timezone skips and 100% statement/branch coverage each. Ruff lint/format and diff checks pass. Test environments set asyncio_default_fixture_loop_scope=function explicitly.
AI assistance: OpenAI Codex found this by code inspection, implemented and tested it at the account owner’s request ("15 TA koro aro"). No personal production incident or independent human review is claimed.