Repository navigation
Conversation
wan9chi
force-pushed
the
feat/cache-listing-ignored-entries
branch
from
October 30, 2026 03:19
7f01a6e to
531c594
Compare
fspy benchmarklinuxmacoswindows |
wan9chi
force-pushed
the
feat/cache-listing-ignored-entries
branch
from
October 30, 2026 04:07
531c594 to
524114b
Compare
wan9chi
force-pushed
the
feat/cache-listing-ignored-entries
branch
from
October 30, 2026 06:31
524114b to
f92e4fd
Compare
…akes it miss Two cases for a task that lists a folder holding its own output folder. In `list_folder_holding_output`, the task makes `gen`, writes `gen/a.txt` and lists the package root, through `vtt fs`. In `typescript_lib_out_dir`, TypeScript 7's `tsc` with no `include` compiles `src` into `lib`: it lists the package root and stats `lib`. Today removing the output folder, as on a clean checkout, is a cache miss naming the folder as removed from the listing, although the cached outputs hold everything in it. A new entry in the listing is a miss too, and must stay one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A task that lists a folder holding its own outputs, like TypeScript 7's `tsc` with no `include` listing the package root that holds its `lib` output folder, pinned those outputs as entries of the listing. Removing them, as on a clean checkout, was a cache miss although a hit restores them. When a listing is fingerprinted, the entries the task can rebuild, a file or symlink it wrote or a folder holding only what it can rebuild, are now left out, and their names are recorded as `ignored_entries` on the inferred input. Validation removes the same names from the current listing before comparing, so they may be missing or present, while any other entry that differs still misses and is named in the message. `Rebuildable` answers whether an entry is rebuildable from the written paths and the folders its walk already found, so no folder is listed again. `.DS_Store` and `dist` stay skipped in every listing and are never recorded. The cache schema version is bumped for the new inferred input format. `typescript_incremental` now runs on Windows too, where `tsc` also lists the package root, which holds the `tsconfig.tsbuildinfo` it wrote. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
wan9chi
force-pushed
the
feat/cache-listing-ignored-entries
branch
from
October 30, 2026 07:08
f92e4fd to
912534a
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
A task that lists a folder holding its own outputs pins those outputs as entries of the listing. TypeScript 7's
tscwith noinclude, for example, lists the package root that holds itsliboutput folder. A clean checkout lacks them, so it misses. Today only an entry nameddistis spared, by a hard-coded skip.Changes
When a listing is fingerprinted, the entries the task can rebuild are left out and their names recorded as
ignored_entries: a file or symlink it wrote, or a rebuildable folder. Validation drops the same names from the current listing before comparing, so they may be missing or present. Any other entry that differs still misses and is named. The cache schema version is bumped.E2E cases:
list_folder_holding_output(synthetic; an unrelated new file still misses) andtypescript_lib_out_dir(TypeScript 7,outDir: "lib").Part of a stack that lets automatic tracking cache tasks which read their own outputs and list the folders holding them, so they also hit on a clean checkout.
🤖 Generated with Claude Code
Note
Medium Risk
Changes post-run fingerprint serialization and validation semantics for directory listings, with a schema bump that invalidates existing caches; incorrect ignored-entry logic could cause stale hits or spurious misses.
Overview
When automatic tracking records a directory listing as a cache input, entries the task can rebuild (files it wrote or output-only folders) are no longer part of the stored listing fingerprint. Their names are saved in new
InferredInput.ignored_entries, and validation strips the same names from the live listing before comparison—so missinglib,gen/, or similar output after a clean checkout can still cache hit and restore outputs.Rebuildablegainsis_rebuildable_entryfor per-entry checks;CACHE_SCHEMA_VERSIONis bumped to 21 (fresh cache). Docs and changelog describe the behavior; e2e fixtures cover a synthetic list-and-write task and TypeScripttscwithoutDir: "lib". Thetypescript_incrementalsnapshot no longer needs a Unix-only cfg now that listing semantics match Windows too.Reviewed by Cursor Bugbot for commit 912534a. Bugbot is set up for automated code reviews on this repo. Configure here.